Skip to content

Conversation

@constantinius
Copy link
Contributor

@constantinius constantinius requested a review from a team as a code owner November 20, 2025 11:32
@linear
Copy link

linear bot commented Nov 20, 2025

@constantinius constantinius requested a review from a team November 20, 2025 11:32
@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.99%. Comparing base (145773b) to head (d0e0751).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/integrations/litellm.py 73.33% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5127      +/-   ##
==========================================
- Coverage   84.00%   83.99%   -0.02%     
==========================================
  Files         180      180              
  Lines       18081    18090       +9     
  Branches     3216     3220       +4     
==========================================
+ Hits        15189    15194       +5     
- Misses       1913     1914       +1     
- Partials      979      982       +3     
Files with missing lines Coverage Δ
sentry_sdk/integrations/litellm.py 79.16% <73.33%> (+1.68%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Contributor

@alexander-alderman-webb alexander-alderman-webb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just some questions regarding the test setup.

@constantinius constantinius merged commit 8596f89 into master Nov 21, 2025
131 of 132 checks passed
@constantinius constantinius deleted the constantinius/fix/integrations/litellm-embedding-improvements branch November 21, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants