Skip to content

fix: Dont break when user sets bytes into event #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2018
Merged

fix: Dont break when user sets bytes into event #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sentry_sdk/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,6 +604,8 @@ def convert_types(obj):
return [convert_types(v) for v in obj]
if not isinstance(obj, string_types + number_types):
return safe_repr(obj)
if isinstance(obj, bytes):
return obj.decode("utf-8", "replace")
return obj


Expand Down
9 changes: 9 additions & 0 deletions tests/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# coding: utf-8
import json
import logging
import pytest
import subprocess
Expand Down Expand Up @@ -281,3 +282,11 @@ def test_scope_initialized_before_client(sentry_init, capture_events):
event, = events

assert "tags" not in event


def test_weird_chars(sentry_init, capture_events):
sentry_init()
events = capture_events()
capture_message(u"föö".encode("latin1"))
event, = events
assert json.loads(json.dumps(event)) == event