Skip to content

Conversation

@antonpirker
Copy link
Contributor

... and replaced it with the native datetime.fromtimestamp.

@codecov
Copy link

codecov bot commented Sep 25, 2024

❌ 3159 Tests Failed:

Tests completed Failed Passed Skipped
16788 3159 13629 1445
View the full list of 3 ❄️ flaky tests
tests.integrations.celery.test_celery test_traces_sampler_gets_task_info_in_sampling_context[<lambda>2]

Flake rate in main: 100.00% (Passed 0 times, Failed 20 times)

Stack Traces | 0s run time
No failure message available
tests.integrations.clickhouse_driver.test_clickhouse_driver test_clickhouse_client_spans

Flake rate in main: 100.00% (Passed 0 times, Failed 266 times)

Stack Traces | 0s run time
No failure message available
tests.integrations.celery.test_celery test_messaging_destination_name_nondefault_exchange

Flake rate in main: 100.00% (Passed 0 times, Failed 181 times)

Stack Traces | 0s run time
No failure message available

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove the function itself too, and also replace the last remaining usage in

crumb["timestamp"] = datetime_from_isoformat(crumb["timestamp"])
with standard datetime.fromisoformat

Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but let's also remove the util (see comment above)

@antonpirker
Copy link
Contributor Author

I guess datetime_from_isoformat is already gone in potel-base branch so I will merge this.

@antonpirker antonpirker merged commit 3ef267c into potel-base Sep 30, 2024
14 of 114 checks passed
@antonpirker antonpirker deleted the antonpirker/potel/remove_datetime_from_isformat branch September 30, 2024 08:16
@sentrivana
Copy link
Contributor

Ah gotcha I think I was looking at master. 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants