-
Notifications
You must be signed in to change notification settings - Fork 565
Removed datetime_from_timestamp ... #3569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed datetime_from_timestamp ... #3569
Conversation
❌ 3159 Tests Failed:
View the full list of 3 ❄️ flaky tests
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove the function itself too, and also replace the last remaining usage in
sentry-python/sentry_sdk/scope.py
Line 1324 in dce589c
| crumb["timestamp"] = datetime_from_isoformat(crumb["timestamp"]) |
datetime.fromisoformat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but let's also remove the util (see comment above)
|
I guess |
|
Ah gotcha I think I was looking at master. 👍🏻 |
... and replaced it with the native
datetime.fromtimestamp.