Skip to content

⚡️ Speed up function _get_db_span_description by 44% #4924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 15, 2025
Merged

⚡️ Speed up function _get_db_span_description by 44% #4924

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3fe619
Optimize _get_db_span_description
codeflash-ai[bot] Oct 2, 2025
db67178
Merge branch 'master' into codeflash/optimize-_get_db_span_descriptio…
misrasaurabh1 Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions sentry_sdk/integrations/redis/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,22 +20,22 @@ def _get_safe_command(name, args):
# type: (str, Sequence[Any]) -> str
command_parts = [name]

name_low = name.lower()
send_default_pii = should_send_default_pii()

for i, arg in enumerate(args):
if i > _MAX_NUM_ARGS:
break

name_low = name.lower()

if name_low in _COMMANDS_INCLUDING_SENSITIVE_DATA:
command_parts.append(SENSITIVE_DATA_SUBSTITUTE)
continue

arg_is_the_key = i == 0
if arg_is_the_key:
command_parts.append(repr(arg))

else:
if should_send_default_pii():
if send_default_pii:
command_parts.append(repr(arg))
else:
command_parts.append(SENSITIVE_DATA_SUBSTITUTE)
Expand Down