Skip to content

fix(gcp): Inject scopes in TimeoutThread exception with GCP #4959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2025
+9 −1
Merged

fix(gcp): Inject scopes in TimeoutThread exception with GCP #4959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion sentry_sdk/integrations/gcp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,12 @@ def sentry_func(functionhandler, gcp_event, *args, **kwargs):
):
waiting_time = configured_time - TIMEOUT_WARNING_BUFFER

timeout_thread = TimeoutThread(waiting_time, configured_time)
timeout_thread = TimeoutThread(
waiting_time,
configured_time,
isolation_scope=scope,
current_scope=sentry_sdk.get_current_scope(),
)

# Starting the thread to raise timeout warning exception
timeout_thread.start()
Expand Down
3 changes: 3 additions & 0 deletions tests/integrations/gcp/test_gcp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,7 @@ def test_timeout_error(run_cloud_function):
functionhandler = None
event = {}
def cloud_function(functionhandler, event):
sentry_sdk.set_tag("cloud_function", "true")
time.sleep(10)
return "3"
"""
Expand All @@ -219,6 +220,8 @@ def cloud_function(functionhandler, event):
assert exception["mechanism"]["type"] == "threading"
assert not exception["mechanism"]["handled"]

assert envelope_items[0]["tags"]["cloud_function"] == "true"


def test_performance_no_error(run_cloud_function):
envelope_items, _ = run_cloud_function(
Expand Down