-
Notifications
You must be signed in to change notification settings - Fork 568
tests(huggingface): Support 1.0.0rc7 #4979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+15
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 54 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
sentrivana
approved these changes
Oct 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could put the repeated logic into a function to dedupe a bit, but also fine the way it is.
shellmayr
pushed a commit
that referenced
this pull request
Oct 30, 2025
Always use "hf-inference" provider for chat completions, which is the existing behavior of our tests prior to version 1.0.0rc7 of `huggingface_hub`. Closes #4978
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The CI fails when you generate
tox.ini, ashuggingface_hubcomplains about a missing API key. See https://github.com/getsentry/sentry-python/actions/runs/18707992581/job/53349699759.Always use
HFInferenceConversational()for chat completions, which is the behavior prior to version 1.0.0rc7 ofhuggingface_hubdue to our mock:sentry-python/tests/integrations/huggingface_hub/test_huggingface_hub.py
Lines 69 to 92 in dcd94ed
We know we have always tested only
HFInferenceConversational()because it's the only provider which does not raise an exception when the API key is missing:https://github.com/huggingface/huggingface_hub/blob/61bc87eb4d774c477ee87c9bf14aa9557ccb4e34/src/huggingface_hub/inference/_providers/hf_inference.py#L31
Issues
Closes #4978
Reminders
tox -e linters.feat:,fix:,ref:,meta:)