-
Couldn't load subscription status.
- Fork 569
fix(integrations): hooking into error tracing function to find out if an execute tool span should be set to error #4986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
… an execute tool span should be set to error
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4986 +/- ##
==========================================
- Coverage 84.00% 83.91% -0.10%
==========================================
Files 178 179 +1
Lines 17839 17876 +37
Branches 3171 3177 +6
==========================================
+ Hits 14986 15000 +14
- Misses 1894 1909 +15
- Partials 959 967 +8
|
…ts-execute-tool-error-reporting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ts-execute-tool-error-reporting
|
@getsentry/owners-python-sdk can someone take a quick glance at this before I merge it? Thanks! |
|
Looks good, I only have one comment for clarification: #4986 (comment). |
Description
We need to patch
agents.util._error_tracing.attach_error_to_current_spanto set execute_tool spans status to errorIssues
Closes https://linear.app/getsentry/issue/TET-1292/issue-associated-with-invoke-agent-instead-of-execute-tool