Skip to content

Conversation

@alexander-alderman-webb
Copy link
Contributor

Description

Introduce a hard limit on the number of elements in the metrics batcher. The size constraint prevents the metrics batcher from using too much memory.

Issues

Closes #5055

Reminders

@alexander-alderman-webb alexander-alderman-webb requested a review from a team as a code owner November 5, 2025 08:45
@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

❌ Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.97%. Comparing base (6a76cc5) to head (b6be967).
⚠️ Report is 3 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/client.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5068      +/-   ##
==========================================
+ Coverage   83.93%   83.97%   +0.04%     
==========================================
  Files         179      179              
  Lines       17928    17943      +15     
  Branches     3190     3192       +2     
==========================================
+ Hits        15047    15067      +20     
+ Misses       1909     1905       -4     
+ Partials      972      971       -1     
Files with missing lines Coverage Δ
sentry_sdk/_metrics_batcher.py 73.86% <100.00%> (+3.98%) ⬆️
sentry_sdk/client.py 83.80% <50.00%> (-0.30%) ⬇️

... and 6 files with indirect coverage changes

@alexander-alderman-webb alexander-alderman-webb merged commit faa327c into master Nov 5, 2025
129 of 130 checks passed
@alexander-alderman-webb alexander-alderman-webb deleted the webb/metrics-batcher-upper-bound branch November 5, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upper bound on metrics batcher

3 participants