Skip to content

Conversation

@constantinius
Copy link
Contributor

Issues

Closes https://linear.app/getsentry/issue/TET-1329/fastmcp-tests

Reminders

@linear
Copy link

linear bot commented Nov 6, 2025

TET-1329 FastMCP: tests

@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.04%. Comparing base (9b497d7) to head (86c5f20).
⚠️ Report is 13 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5075      +/-   ##
==========================================
+ Coverage   83.96%   84.04%   +0.08%     
==========================================
  Files         179      180       +1     
  Lines       17951    18030      +79     
  Branches     3194     3209      +15     
==========================================
+ Hits        15073    15154      +81     
+ Misses       1906     1899       -7     
- Partials      972      977       +5     

see 21 files with indirect coverage changes

@constantinius constantinius marked this pull request as ready for review November 6, 2025 10:11
@constantinius constantinius requested a review from a team as a code owner November 6, 2025 10:11
dramatiq: TESTPATH=tests/integrations/dramatiq
falcon: TESTPATH=tests/integrations/falcon
fastapi: TESTPATH=tests/integrations/fastapi
fastmcp: TESTPATH=tests/integrations/fastmcp
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The fastmcp tox environment's TESTPATH in tox.ini line 808 points to a non-existent directory, preventing test discovery.
Severity: HIGH | Confidence: 1.00

🔍 Detailed Analysis

The fastmcp tox environment's TESTPATH is incorrectly configured in tox.ini at line 808. It points to tests/integrations/fastmcp, a non-existent directory. The actual test file, test_fastmcp.py, resides in tests/integrations/mcp. This misconfiguration prevents pytest from discovering and executing any tests for the fastmcp integration suite, resulting in a silent failure where no tests are run.

💡 Suggested Fix

Update tox.ini line 808 to set fastmcp: TESTPATH=tests/integrations/mcp. This will correctly direct pytest to the location of the fastmcp integration tests.

🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: tox.ini#L808

Potential issue: The `fastmcp` tox environment's `TESTPATH` is incorrectly configured in
`tox.ini` at line 808. It points to `tests/integrations/fastmcp`, a non-existent
directory. The actual test file, `test_fastmcp.py`, resides in `tests/integrations/mcp`.
This misconfiguration prevents `pytest` from discovering and executing any tests for the
`fastmcp` integration suite, resulting in a silent failure where no tests are run.

Did we get this right? 👍 / 👎 to inform future reviews.

Copy link
Contributor

@alexander-alderman-webb alexander-alderman-webb Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put the new tests in a new tests/integrations/fastmcp directory.

If we changed the TESTPATH of the fastmcp entry to be tests/integrations/mcp, then we would be running mcp tests twice in our CI.

@alexander-alderman-webb
Copy link
Contributor

alexander-alderman-webb commented Nov 7, 2025

There are CI failures due to version bumps picked up by generate_tox.py. We're fixing them

@constantinius constantinius merged commit f89d77b into master Nov 18, 2025
132 checks passed
@constantinius constantinius deleted the constantinius/test/integrations/fastmcp branch November 18, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants