feat(integrations): implement context management for invoke_agent spans #5089
+113
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced context variables to manage nested invoke_agent spans safely. - Added functions to push and pop spans from the context stack. - Updated existing code to utilize context variables instead of Sentry scope for agent management. - Enhanced execute_tool_span to support parent-child relationships between spans. This change improves the handling of agent spans during nested calls, ensuring better traceability and isolation of spans in asynchronous contexts.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
❌ 21 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
sentrivana
approved these changes
Nov 12, 2025
Contributor
sentrivana
left a comment
sentrivana
left a comment
There was a problem hiding this comment.
Thanks for reworking this with iso scopes. Looks good to me, but please check the cursor comment if it applies.
…context-management-for-invoke_agent-spans
constantinius
deleted the
constantinius/feat/integrations/implement-context-management-for-invoke_agent-spans
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves the handling of agent spans during nested calls, ensuring better traceability and isolation of spans in asynchronous contexts.
Description
Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)