Skip to content

Conversation

@sentrivana
Copy link
Contributor

Description

See #4907

Issues

Closes #4907
Closes https://linear.app/getsentry/issue/PY-1878/ensure-the-python-sdk-sets-sentryorigin-for-structured-logs-according

Reminders

@linear
Copy link

linear bot commented Nov 17, 2025

@sentrivana sentrivana marked this pull request as ready for review November 17, 2025 09:56
@sentrivana sentrivana requested a review from a team as a code owner November 17, 2025 09:56
Copy link
Contributor

@alexander-alderman-webb alexander-alderman-webb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we should check if anyone queries for the attribute.

@sentrivana sentrivana merged commit c4d0ba8 into master Nov 18, 2025
132 checks passed
@sentrivana sentrivana deleted the ivana/fix-log-origin branch November 18, 2025 07:08
@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.00%. Comparing base (c6ad9ac) to head (a3faa6c).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5112   +/-   ##
=======================================
  Coverage   84.00%   84.00%           
=======================================
  Files         180      180           
  Lines       18023    18023           
  Branches     3205     3205           
=======================================
  Hits        15141    15141           
  Misses       1905     1905           
  Partials      977      977           
Files with missing lines Coverage Δ
sentry_sdk/integrations/logging.py 87.58% <100.00%> (ø)
sentry_sdk/integrations/loguru.py 84.21% <100.00%> (ø)

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ensure the Python SDK sets sentry.origin for Structured Logs according to the documentation (converted to project)

3 participants