Skip to content

Conversation

@alexander-alderman-webb
Copy link
Contributor

Description

Set the server.address attribute on metrics analogously to logs.

Issues

See https://linear.app/getsentry/issue/SDK-60/attach-serveraddress-as-a-default-attribute-to-metrics.

Reminders

@alexander-alderman-webb alexander-alderman-webb requested a review from a team as a code owner November 18, 2025 07:52
@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.02%. Comparing base (c4d0ba8) to head (3148c74).
⚠️ Report is 3 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/client.py 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5113       +/-   ##
===========================================
+ Coverage   70.26%   84.02%   +13.75%     
===========================================
  Files         180      180               
  Lines       18023    18029        +6     
  Branches     3205     3208        +3     
===========================================
+ Hits        12664    15148     +2484     
+ Misses       4672     1905     -2767     
- Partials      687      976      +289     
Files with missing lines Coverage Δ
sentry_sdk/client.py 83.71% <66.66%> (+1.04%) ⬆️

... and 56 files with indirect coverage changes

@alexander-alderman-webb alexander-alderman-webb merged commit 66be3d2 into master Nov 18, 2025
131 of 132 checks passed
@alexander-alderman-webb alexander-alderman-webb deleted the webb/metrics-server-address branch November 18, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants