feat: add instrumentation to embedding functions for various backends #5120
+814
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5120 +/- ##
==========================================
+ Coverage 83.95% 84.01% +0.06%
==========================================
Files 180 180
Lines 18077 18168 +91
Branches 3215 3227 +12
==========================================
+ Hits 15176 15264 +88
+ Misses 1919 1916 -3
- Partials 982 988 +6
|
Merged
sentrivana
added a commit
that referenced
this pull request
Nov 20, 2025
### Description Regenerating tox because we need to update the config for the langchain test suite in #5120 and I don't want to pull in lots of unrelated changes on the feature branch. Dramatiq 2.0 has been released and our tests fail on it. Excluding it for now, we will follow up in #5123. #### Issues <!-- * resolves: #1234 * resolves: LIN-1234 --> #### Reminders - Please add tests to validate your changes, and lint your code using `tox -e linters`. - Add GH Issue ID _&_ Linear ID (if applicable) - PR title should use [conventional commit](https://develop.sentry.dev/engineering-practices/commit-messages/#type) style (`feat:`, `fix:`, `ref:`, `meta:`) - For external contributors: [CONTRIBUTING.md](https://github.com/getsentry/sentry-python/blob/master/CONTRIBUTING.md), [Sentry SDK development docs](https://develop.sentry.dev/sdk/), [Discord community](https://discord.gg/Ww9hbqr)
sentrivana
approved these changes
Nov 20, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| if hasattr(provider_class, "aembed_query"): | ||
| provider_class.aembed_query = _wrap_async_embedding_method( | ||
| provider_class.aembed_query | ||
| ) |
There was a problem hiding this comment.
Bug: Missing guard against double-wrapping embedding methods
The _patch_embeddings_provider function lacks a guard to prevent double-wrapping when setup_once is called multiple times. Each call wraps the methods again, creating nested wrappers that can cause incorrect behavior. Other integrations like Celery, Huey, and Beam use a _sentry_is_patched flag to prevent this issue. The tests explicitly call setup_once multiple times, which triggers this bug.
constantinius
deleted the
constantinius/feat/integrations/langchain-genai-embeddings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wrap the backends OpenAIEmbeddings, AzureOpenAIEmbeddings, VertexAIEmbeddings, BedrockEmbeddings, CohereEmbeddings, MistralAIEmbeddings, HuggingFaceEmbeddings, OllamaEmbeddings and their embed_documents, embed_query, aembed_documents, aembed_query methods to properly instrument embeddings
Issues
Closes https://linear.app/getsentry/issue/TET-1460/add-embedding-support-for-langchain
Reminders
tox -e linters.feat:,fix:,ref:,meta:)