Skip to content

Conversation

@alexander-alderman-webb
Copy link
Contributor

@alexander-alderman-webb alexander-alderman-webb commented Nov 20, 2025

Description

Parameterize dramatiq tests on the fail_fast parameter of StubBroker.join. The default value is flipped to True in version 2.0.0 of dramatiq. See https://dramatiq.io/changelog.html.

Issues

Closes #5123

Reminders

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.98%. Comparing base (48ddf8c) to head (9ecd05b).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5125      +/-   ##
==========================================
+ Coverage   83.95%   83.98%   +0.03%     
==========================================
  Files         180      180              
  Lines       18077    18081       +4     
  Branches     3215     3216       +1     
==========================================
+ Hits        15176    15185       +9     
+ Misses       1919     1914       -5     
  Partials      982      982              

see 3 files with indirect coverage changes

@alexander-alderman-webb alexander-alderman-webb marked this pull request as ready for review November 20, 2025 10:55
@alexander-alderman-webb alexander-alderman-webb requested a review from a team as a code owner November 20, 2025 10:55
@alexander-alderman-webb alexander-alderman-webb merged commit c63e8d8 into master Nov 20, 2025
132 checks passed
@alexander-alderman-webb alexander-alderman-webb deleted the webb/test-dramatiq branch November 20, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support dramatiq 2.x

3 participants