Skip to content

fix: Fix list attribute type #5417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sentrivana merged 6 commits into from
Feb 4, 2026
+12 −22
Merged

fix: Fix list attribute type #5417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
848ee28
fix: Fix list attribute type
sentrivana Feb 4, 2026
538129a
fix tests
sentrivana Feb 4, 2026
ba9df31
.
sentrivana Feb 4, 2026
afa8b30
.
sentrivana Feb 4, 2026
e402f0a
Merge branch 'master' into ivana/fix-array-type
sentrivana Feb 4, 2026
bbdf292
.
sentrivana Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions sentry_sdk/_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,10 +241,7 @@ class SDKInfo(TypedDict):
"boolean",
"double",
"integer",
"string[]",
"boolean[]",
"double[]",
"integer[]",
"array",
],
"value": AttributeValue,
},
Expand Down
13 changes: 3 additions & 10 deletions sentry_sdk/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2097,19 +2097,12 @@ def serialize_attribute(val: "AttributeValue") -> "SerializedAttributeValue":

if isinstance(val, list):
if not val:
return {"value": [], "type": "string[]"}
return {"value": [], "type": "array"}

# Only lists of elements of a single type are supported
list_types: 'dict[type, Literal["string[]", "integer[]", "double[]", "boolean[]"]]' = {
str: "string[]",
int: "integer[]",
float: "double[]",
bool: "boolean[]",
}

ty = type(val[0])
if ty in list_types and all(type(v) is ty for v in val):
return {"value": val, "type": list_types[ty]}
if ty in (int, str, bool, float) and all(type(v) is ty for v in val):
return {"value": val, "type": "array"}

# Coerce to string if we don't know what to do with the value. This should
# never happen as we pre-format early in format_attribute, but let's be safe.
Expand Down
8 changes: 4 additions & 4 deletions tests/test_logs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,11 +692,11 @@ def test_log_array_attributes(sentry_init, capture_envelopes):

assert serialized_attributes["string_list"] == {
"value": ["value1", "value2"],
"type": "string[]",
"type": "array",
}
assert serialized_attributes["int_tuple"] == {
"value": [3, 2, 1, 4],
"type": "integer[]",
"type": "array",
}
assert serialized_attributes["inhomogeneous_tuple"] == {
"value": "(3, 2.0, 1, 4)",
Expand All @@ -705,11 +705,11 @@ def test_log_array_attributes(sentry_init, capture_envelopes):

assert serialized_attributes["float_list"] == {
"value": [3.0, 3.5, 4.2],
"type": "double[]",
"type": "array",
}
assert serialized_attributes["bool_tuple"] == {
"value": [False, False, True],
"type": "boolean[]",
"type": "array",
}
assert serialized_attributes["inhomogeneous_list"] == {
"value": "[3.2, True, None]",
Expand Down
8 changes: 4 additions & 4 deletions tests/test_metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,11 +425,11 @@ def test_log_array_attributes(sentry_init, capture_envelopes):

assert serialized_attributes["string_list.attribute"] == {
"value": ["value1", "value2"],
"type": "string[]",
"type": "array",
}
assert serialized_attributes["int_tuple.attribute"] == {
"value": [3, 2, 1, 4],
"type": "integer[]",
"type": "array",
}
assert serialized_attributes["inhomogeneous_tuple.attribute"] == {
"value": "(3, 2.0, 1, 4)",
Expand All @@ -438,11 +438,11 @@ def test_log_array_attributes(sentry_init, capture_envelopes):

assert serialized_attributes["float_list.attribute"] == {
"value": [3.0, 3.5, 4.2],
"type": "double[]",
"type": "array",
}
assert serialized_attributes["bool_tuple.attribute"] == {
"value": [False, False, True],
"type": "boolean[]",
"type": "array",
}
assert serialized_attributes["inhomogeneous_list.attribute"] == {
"value": "[3.2, True, None]",
Expand Down
Loading