Skip to content

fix(tracing): Discard empty Route Change transactions when route is undefined #5387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 20, 2025
Merged

fix(tracing): Discard empty Route Change transactions when route is undefined #5387

merged 5 commits into from
Nov 20, 2025
+159 −19

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented Nov 19, 2025 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

  • Added ignoreEmptyRouteChangeTransactions() utility function that:
    • Detects transactions that still have the default "Route Change" name
    • Checks if they never received any route information
    • Verifies they were never processed by the state listener
    • Discards them and records as dropped for observability

Called from:

  • reactNavigationIntegration (React Navigation v5+)
  • reactNativeNavigationIntegration (React Native Navigation)

💡 Motivation and Context

Fixes #3991

💚 How did you test it?

CI, Manual

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

@antonis antonis added the ready-to-merge Triggers the full CI test suite label Nov 19, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2025 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 493.80 ms 535.31 ms 41.52 ms
Size 43.75 MiB 48.04 MiB 4.29 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
98f632c 424.25 ms 435.48 ms 11.23 ms
c9e95bd 428.04 ms 458.70 ms 30.65 ms
5c16cdc+dirty 423.48 ms 452.35 ms 28.88 ms
4a17c8f+dirty 406.62 ms 400.58 ms -6.04 ms
0d6e618+dirty 414.00 ms 416.90 ms 2.90 ms
d1fd647+dirty 413.02 ms 459.72 ms 46.70 ms
eb07ba3 470.04 ms 473.35 ms 3.31 ms
3bd3f0d+dirty 447.21 ms 472.31 ms 25.10 ms
3e0a5f9 401.72 ms 394.98 ms -6.74 ms
ba75c7c 367.72 ms 369.16 ms 1.44 ms

App size

Revision Plain With Sentry Diff
98f632c 17.75 MiB 20.15 MiB 2.41 MiB
c9e95bd 17.75 MiB 19.68 MiB 1.93 MiB
5c16cdc+dirty 17.75 MiB 19.68 MiB 1.94 MiB
4a17c8f+dirty 43.75 MiB 47.99 MiB 4.24 MiB
0d6e618+dirty 43.75 MiB 47.99 MiB 4.24 MiB
d1fd647+dirty 17.75 MiB 19.70 MiB 1.95 MiB
eb07ba3 17.75 MiB 20.15 MiB 2.41 MiB
3bd3f0d+dirty 17.75 MiB 19.70 MiB 1.95 MiB
3e0a5f9 17.75 MiB 20.15 MiB 2.41 MiB
ba75c7c 17.75 MiB 20.15 MiB 2.41 MiB

Previous results on branch: antonis/fix-empty-route-change

Startup times

Revision Plain With Sentry Diff
3b0ffd1+dirty 409.31 ms 425.42 ms 16.11 ms
fe700ea+dirty 421.74 ms 448.55 ms 26.81 ms

App size

Revision Plain With Sentry Diff
3b0ffd1+dirty 43.75 MiB 48.02 MiB 4.27 MiB
fe700ea+dirty 43.75 MiB 48.02 MiB 4.27 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2025 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 369.67 ms 387.82 ms 18.14 ms
Size 43.94 MiB 48.87 MiB 4.93 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
1e7a472+dirty 319.58 ms 372.29 ms 52.71 ms
77061ed+dirty 359.40 ms 424.10 ms 64.70 ms
4a17c8f+dirty 368.54 ms 381.43 ms 12.89 ms
0d6e618+dirty 369.02 ms 387.69 ms 18.67 ms
46e3d54+dirty 436.24 ms 474.18 ms 37.94 ms
23080e5+dirty 347.29 ms 381.87 ms 34.58 ms
5c16cdc+dirty 375.45 ms 426.62 ms 51.17 ms
459a438+dirty 359.50 ms 390.53 ms 31.03 ms
f70acbf+dirty 520.12 ms 558.91 ms 38.79 ms
f081f58+dirty 468.47 ms 492.64 ms 24.17 ms

App size

Revision Plain With Sentry Diff
1e7a472+dirty 7.15 MiB 8.43 MiB 1.28 MiB
77061ed+dirty 7.15 MiB 8.41 MiB 1.26 MiB
4a17c8f+dirty 43.94 MiB 48.82 MiB 4.88 MiB
0d6e618+dirty 43.94 MiB 48.82 MiB 4.88 MiB
46e3d54+dirty 43.94 MiB 48.82 MiB 4.88 MiB
23080e5+dirty 7.15 MiB 8.41 MiB 1.26 MiB
5c16cdc+dirty 7.15 MiB 8.41 MiB 1.26 MiB
459a438+dirty 7.15 MiB 8.42 MiB 1.27 MiB
f70acbf+dirty 7.15 MiB 8.41 MiB 1.26 MiB
f081f58+dirty 43.94 MiB 48.82 MiB 4.88 MiB

Previous results on branch: antonis/fix-empty-route-change

Startup times

Revision Plain With Sentry Diff
3b0ffd1+dirty 433.64 ms 462.70 ms 29.05 ms
fe700ea+dirty 401.06 ms 419.78 ms 18.71 ms

App size

Revision Plain With Sentry Diff
3b0ffd1+dirty 43.94 MiB 48.85 MiB 4.91 MiB
fe700ea+dirty 43.94 MiB 48.85 MiB 4.91 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2025 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1211.04 ms 1221.89 ms 10.85 ms
Size 3.41 MiB 4.59 MiB 1.18 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e2fa43d+dirty 1224.43 ms 1235.40 ms 10.98 ms
98f632c+dirty 1221.38 ms 1229.26 ms 7.88 ms
95aaf8a+dirty 1206.83 ms 1213.65 ms 6.81 ms
bc9680d+dirty 1228.57 ms 1233.64 ms 5.07 ms
266bc7e+dirty 1217.73 ms 1222.30 ms 4.57 ms
df83aad+dirty 1202.06 ms 1203.83 ms 1.77 ms
0b64753+dirty 1225.77 ms 1232.98 ms 7.21 ms
3bd3f0d+dirty 1230.18 ms 1243.41 ms 13.22 ms
955f2eb+dirty 1225.78 ms 1239.27 ms 13.49 ms
1853710+dirty 1213.67 ms 1226.35 ms 12.67 ms

App size

Revision Plain With Sentry Diff
e2fa43d+dirty 3.19 MiB 4.38 MiB 1.19 MiB
98f632c+dirty 3.19 MiB 4.38 MiB 1.19 MiB
95aaf8a+dirty 3.19 MiB 4.44 MiB 1.25 MiB
bc9680d+dirty 3.19 MiB 4.38 MiB 1.19 MiB
266bc7e+dirty 3.41 MiB 4.58 MiB 1.17 MiB
df83aad+dirty 3.41 MiB 4.57 MiB 1.16 MiB
0b64753+dirty 3.19 MiB 4.55 MiB 1.36 MiB
3bd3f0d+dirty 3.19 MiB 4.55 MiB 1.37 MiB
955f2eb+dirty 3.19 MiB 4.55 MiB 1.36 MiB
1853710+dirty 3.19 MiB 4.48 MiB 1.29 MiB

Previous results on branch: antonis/fix-empty-route-change

Startup times

Revision Plain With Sentry Diff
fe700ea+dirty 1209.73 ms 1208.83 ms -0.90 ms
3b0ffd1+dirty 1206.47 ms 1202.45 ms -4.02 ms

App size

Revision Plain With Sentry Diff
fe700ea+dirty 3.41 MiB 4.58 MiB 1.17 MiB
3b0ffd1+dirty 3.41 MiB 4.58 MiB 1.17 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2025 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1218.17 ms 1217.43 ms -0.74 ms
Size 3.41 MiB 4.59 MiB 1.18 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e2fa43d+dirty 1216.04 ms 1232.65 ms 16.61 ms
98f632c+dirty 1236.40 ms 1241.62 ms 5.22 ms
95aaf8a+dirty 1234.78 ms 1241.94 ms 7.16 ms
bc9680d+dirty 1221.41 ms 1241.47 ms 20.06 ms
266bc7e+dirty 1190.56 ms 1191.47 ms 0.91 ms
df83aad+dirty 1187.20 ms 1190.55 ms 3.36 ms
0b64753+dirty 1232.49 ms 1226.96 ms -5.53 ms
3bd3f0d+dirty 1231.51 ms 1229.10 ms -2.41 ms
955f2eb+dirty 1235.06 ms 1253.88 ms 18.81 ms
1853710+dirty 1224.35 ms 1230.18 ms 5.84 ms

App size

Revision Plain With Sentry Diff
e2fa43d+dirty 2.63 MiB 3.81 MiB 1.18 MiB
98f632c+dirty 2.63 MiB 3.81 MiB 1.18 MiB
95aaf8a+dirty 2.63 MiB 3.87 MiB 1.24 MiB
bc9680d+dirty 2.63 MiB 3.81 MiB 1.18 MiB
266bc7e+dirty 3.41 MiB 4.58 MiB 1.17 MiB
df83aad+dirty 3.41 MiB 4.57 MiB 1.16 MiB
0b64753+dirty 2.63 MiB 3.98 MiB 1.35 MiB
3bd3f0d+dirty 2.63 MiB 3.99 MiB 1.35 MiB
955f2eb+dirty 2.63 MiB 3.98 MiB 1.35 MiB
1853710+dirty 2.63 MiB 3.91 MiB 1.28 MiB

Previous results on branch: antonis/fix-empty-route-change

Startup times

Revision Plain With Sentry Diff
fe700ea+dirty 1224.35 ms 1223.83 ms -0.52 ms
3b0ffd1+dirty 1213.04 ms 1218.24 ms 5.20 ms

App size

Revision Plain With Sentry Diff
fe700ea+dirty 3.41 MiB 4.58 MiB 1.17 MiB
3b0ffd1+dirty 3.41 MiB 4.58 MiB 1.17 MiB

@antonis antonis marked this pull request as ready for review November 19, 2025 14:47
antonis
antonis commented Nov 19, 2025
View reviewed changes
@antonis
Copy link
Contributor Author

antonis commented Nov 20, 2025

@sentry review

lucas-zimerman
lucas-zimerman approved these changes Nov 20, 2025
View reviewed changes
Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@antonis antonis merged commit c198191 into main Nov 20, 2025
105 of 108 checks passed
@antonis antonis deleted the antonis/fix-empty-route-change branch November 20, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucas-zimerman lucas-zimerman lucas-zimerman approved these changes

@alwx alwx Awaiting requested review from alwx alwx is a code owner

Assignees

No one assigned

Labels

ready-to-merge Triggers the full CI test suite

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Do not send empty Route Change Transactions

3 participants

@antonis @lucas-zimerman