Errors being swallowed by raven when jobs fail (ActiveJob with sidekiq adapter)

[j-manu]

Clone the repo - https://github.com/debug-poc/sidekiq-raven-activejob

With sentry gem

• Push a new job "TestJob.perform_later(1)"
• bundle exec sidekiq
• The job should execute successfully

Without sentry gem

• Stop sidekiq
• Remove sentry-raven from Gemfile
• Push a new job "TestJob.perform_later(1)"
• bundle exec sidekiq
• The job should now fail

[dcramer]

@j-manu version of the gem? I just want to confirm this wasnt resolved with the bugfix release.

[coop]

@dcramer I can confirm that we're seeing the issue in production using 0.15.0. The issue was introduced in 0.14.0 with https://github.com/getsentry/raven-ruby/pull/327.

+module Raven
+  class Rails
+    module ActiveJob
+      def self.included(base)
+        base.class_eval do
+          rescue_from(Exception) do |exception|
+            # Do not capture exceptions when using Sidekiq so we don't capture
+            # The same exception twice.
+            unless self.class.queue_adapter.to_s == 'ActiveJob::QueueAdapters::SidekiqAdapter'
+              Raven.capture_exception(exception, :extra => { :active_job => self.class.name })
+              raise exception
+            end
+          end
+        end
+      end
+    end
+  end
+end

This code (slightly modified in 0.15.0) is the culprit as it swallows exceptions raised by ActiveJob using the sidekiq adapter, by the time sidekiq comes around there is no exception to raise.

[JonathonMA]

👍

As well as suppressing the errors from reaching sidekiq for handling, it also affects jobs executed inline via perform_now. You can see if in the proof-of-concept repo too:

$ bin/rails runner "TestJob.perform_now(1)"

Should fail messily, but just silently succeeds.

[dcramer]

Can you confirm this is still present on 0.15.1? We had pushed it to rubygems but failed to tag in repo.

[coop]

I will double check but just looking at the source code it's obvious that
active job is using rescue_from and not reraising for sidekiq - I expect it
to still fail.

On Tue, 22 Sep 2015 at 5:26 PM, David Cramer notifications@github.com
wrote:

Can you confirm this is still present on 0.15.1? We had pushed it to
rubygems but failed to tag in repo.

—
Reply to this email directly or view it on GitHub
https://github.com/getsentry/raven-ruby/issues/368#issuecomment-142201470
.

[j-manu]

The proof of concept repo I shared in the report uses 0.15.1
On 22 Sep 2015 12:56 pm, "David Cramer" notifications@github.com wrote:

Can you confirm this is still present on 0.15.1? We had pushed it to
rubygems but failed to tag in repo.

—
Reply to this email directly or view it on GitHub
https://github.com/getsentry/raven-ruby/issues/368#issuecomment-142201470
.

[dcramer]

@coop @j-manu for now I'm going to revert #327 until we sort this out.

That said, my understanding is that our other sidekiq integration would have correctly caught it. Unfortunately I'm not a Rubyist myself so I'm a bit at a loss with how some of the frameworks operate.

[dcramer]

We've pushed out 0.15.2 which will includes the revert. We'll investigate further before merging ActiveJob integration back in.

Sorry all!