ActiveSupportLogger should only record events that has a started time #1132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because `ActiveSupport::Notifications.publish` can be used to publish anything, whether it's standard Rails instrumentation payload, a string, or even a custom object, it's dangerous for the logger to accept anything that's being published. So this commit filters out events that are not compatible with the default Rails instrumentation format to avoid issues.
|
fyi the fix has been released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
ActiveSupport::Notifications.publishcan be used to publish anything, whether it's a standard Rails instrumentation payload, a string, or even a custom object, it's dangerous for the logger to accept anything that's being published.So this PR filters out events that are not compatible with the default Rails instrumentation format to avoid issues.
closes #1131