Skip to content

Conversation

@st0012
Copy link
Contributor

@st0012 st0012 commented Jun 4, 2023

  1. Since Ruby 3.2 has gone out for almost half of year, we should be able to use it for special suites like generating coverage or with --enable-frozen-string-literal falg
  2. Given that we rarely adopt the latest Ruby features and Ruby has strong emphasise on backward-compatibility, I think testing against head just increases the chance of broken build unnecessarily. So I'm stopping testing against Ruby head now.

#skip-changelog

@st0012 st0012 added the testing label Jun 4, 2023
@st0012 st0012 requested a review from sl0thentr0py June 4, 2023 17:10
@st0012 st0012 self-assigned this Jun 4, 2023
@codecov
Copy link

codecov bot commented Jun 4, 2023

Codecov Report

Patch coverage: 85.71% and project coverage change: +4.58 🎉

Comparison is base (fea18fe) 78.62% compared to head (3c063a2) 83.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2052      +/-   ##
==========================================
+ Coverage   78.62%   83.20%   +4.58%     
==========================================
  Files         114      119       +5     
  Lines        5268     5651     +383     
==========================================
+ Hits         4142     4702     +560     
+ Misses       1126      949     -177     
Impacted Files Coverage Δ
...entry-rails/lib/sentry/rails/capture_exceptions.rb 96.77% <85.71%> (-3.23%) ⬇️

... and 22 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@st0012 st0012 merged commit 5258900 into master Jun 4, 2023
@st0012 st0012 deleted the update-ci-rubies branch June 4, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants