Skip to content

Conversation

sl0thentr0py
Copy link
Member

@sl0thentr0py sl0thentr0py commented Oct 7, 2025

Issues

#skip-changelog

@sl0thentr0py sl0thentr0py force-pushed the neel/cleanup-hub-tx-init branch from 0e0fd0e to 92a1327 Compare October 7, 2025 14:15
end

# @!visibility private
def sdk_logger
Copy link
Member Author

@sl0thentr0py sl0thentr0py Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generalized this to fallback to the global logger

Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.27%. Comparing base (328e1d2) to head (af1f7fe).
⚠️ Report is 2 commits behind head on 6.0-dev.

Additional details and impacted files
@@           Coverage Diff            @@
##           6.0-dev    #2739   +/-   ##
========================================
  Coverage    97.27%   97.27%           
========================================
  Files          130      130           
  Lines         5216     5217    +1     
========================================
+ Hits          5074     5075    +1     
  Misses         142      142           
Components Coverage Δ
sentry-ruby 97.48% <100.00%> (+<0.01%) ⬆️
sentry-rails 96.74% <ø> (ø)
sentry-sidekiq 96.57% <ø> (ø)
sentry-resque 94.44% <ø> (ø)
sentry-delayed_job 94.68% <ø> (ø)
sentry-opentelemetry 99.31% <ø> (ø)
Files with missing lines Coverage Δ
sentry-ruby/lib/sentry/hub.rb 97.93% <100.00%> (ø)
sentry-ruby/lib/sentry/transaction.rb 98.74% <100.00%> (ø)
sentry-ruby/lib/sentry/utils/logging_helper.rb 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sl0thentr0py sl0thentr0py marked this pull request as ready for review October 7, 2025 14:21
@sl0thentr0py sl0thentr0py mentioned this pull request Oct 7, 2025
cursor[bot]

This comment was marked as outdated.

@sl0thentr0py sl0thentr0py force-pushed the neel/cleanup-hub-tx-init branch from 92a1327 to 085b075 Compare October 7, 2025 14:34
cursor[bot]

This comment was marked as outdated.

@sl0thentr0py sl0thentr0py force-pushed the neel/cleanup-hub-tx-init branch from 085b075 to af1f7fe Compare October 7, 2025 14:46
Copy link
Collaborator

@solnic solnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some questions

@sl0thentr0py sl0thentr0py requested a review from solnic October 9, 2025 12:26
@sl0thentr0py sl0thentr0py merged commit a484eca into 6.0-dev Oct 9, 2025
266 of 267 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/cleanup-hub-tx-init branch October 9, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants