-
-
Notifications
You must be signed in to change notification settings - Fork 518
Remove hub from Transaction#initialize #2739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0e0fd0e
to
92a1327
Compare
end | ||
|
||
# @!visibility private | ||
def sdk_logger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generalized this to fallback to the global logger
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 6.0-dev #2739 +/- ##
========================================
Coverage 97.27% 97.27%
========================================
Files 130 130
Lines 5216 5217 +1
========================================
+ Hits 5074 5075 +1
Misses 142 142
🚀 New features to boost your workflow:
|
92a1327
to
085b075
Compare
085b075
to
af1f7fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some questions
Issues
#skip-changelog