Skip to content

Conversation

@solnic
Copy link
Collaborator

@solnic solnic commented Nov 17, 2025

Fixes #2773

@solnic solnic linked an issue Nov 17, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.18%. Comparing base (6049bfd) to head (f92be4c).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2777      +/-   ##
==========================================
+ Coverage   90.17%   90.18%   +0.01%     
==========================================
  Files         132      132              
  Lines        5281     5287       +6     
==========================================
+ Hits         4762     4768       +6     
  Misses        519      519              
Components Coverage Δ
sentry-ruby 97.25% <100.00%> (+<0.01%) ⬆️
sentry-rails 55.66% <ø> (ø)
sentry-sidekiq 95.05% <ø> (ø)
sentry-resque 94.44% <ø> (ø)
sentry-delayed_job 94.68% <ø> (ø)
sentry-opentelemetry 99.31% <ø> (ø)
Files with missing lines Coverage Δ
sentry-ruby/lib/sentry/client.rb 99.33% <100.00%> (+0.01%) ⬆️
sentry-ruby/lib/sentry/utils/encoding_helper.rb 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@solnic solnic force-pushed the 2773-invalid-utf-8-for-logs branch from 1adc685 to f92be4c Compare November 17, 2025 14:19
@solnic solnic marked this pull request as ready for review November 17, 2025 14:20
@solnic solnic merged commit 2d8fc6e into master Nov 17, 2025
126 checks passed
@solnic solnic deleted the 2773-invalid-utf-8-for-logs branch November 17, 2025 15:42
module Sentry
module Utils
module EncodingHelper
EMPTY_STRING = ""
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi, just wondering where this constant is used?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid UTF-8 for logs

4 participants