Change Rails.inject to look for the railties gem, not rails.
#323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`rails` is a meta gem that can be skipped in a Rails app if we don't want to install gems like `actionmailer`, `activerecord` or `activejob`, while the `railties` gem is always present in a Rails app. To ensure that Raven is properly loaded when the `rails` gem is not present we look for the `railties` gem, not `rails` in the `Gem.loaded_specs` Hash.
Contributor
|
👍 Great catch. |
nateberkopec
added a commit
that referenced
this pull request
Apr 30, 2015
Change `Rails.inject` to look for the `railties` gem, not `rails`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
railsis a meta gem that can be skipped in a Rails app if we don't want to install gems likeactionmailer,activerecordoractivejob, while therailtiesgem is always present in a Rails app.To ensure that Raven is properly loaded when the
railsgem is not present we look for therailtiesgem, notrailsin theGem.loaded_specsHash.