config to allow disabling credit card number sanitization #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for still using SanitizeData, while disabling this specific value sanitizer, which is broad enough to capture any other 13-16 digit numbers as well.
Contributor
Great point! |
nateberkopec
added a commit
that referenced
this pull request
May 7, 2015
config to allow disabling credit card number sanitization
Contributor
Author
|
thanks for the snappy response! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for still using SanitizeData, while disabling this specific value
sanitizer, which is broad enough to capture any other 13-16 digit numbers as well.
As discussed in https://github.com/getsentry/raven-ruby/issues/328
Overall I kinda liked my second suggestion better, splitting the credit card sanitizer into a separate processor, but decided against it for backwards compatibility reasons. It'd be sad if people suddenly lost that sanitization because they were doing something like