Use send_event when capturing an exception #332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The #send method is deprecated, and causes noisy warnings.
Contributor
|
Derp! Sorry, I thought I caught all of these. Thanks. |
nateberkopec
added a commit
that referenced
this pull request
May 12, 2015
Use send_event when capturing an exception
Contributor
|
I'll push out a tiny version release tonight to fix. |
Contributor
Author
|
\o/ Thanks much! :) |
Contributor
|
0.13.3 has been pushed to rubygems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raven.send, which happens to be used fromRaven.capture_typeis deprecated, and causes deprecation warnings. I would count this as a bug, because the end user cannot directly avoid the warning if they useRaven.capture_typedirectly—or in our case using it through the Rack integration middleware.This PR makes
capture_typeusesend_eventand avoid the warning altogether, and changes the specs to match.All green: 170 examples, 0 failures.
Thanks!