Skip to content

Better handling of unreachable file context #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2015
Merged

Better handling of unreachable file context #335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/raven/event.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,7 @@ def self._source_lines(_path, _from, _to)
end

def get_file_context(filename, lineno, context)
return nil, nil, nil unless Raven::LineCache.is_valid_file(filename)
lines = (2 * context + 1).times.map do |i|
Raven::LineCache.getline(filename, lineno - context + i)
end
Expand Down
11 changes: 9 additions & 2 deletions lib/raven/linecache.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,24 @@ class LineCache
class << self
CACHE = {}

def is_valid_file(path)
lines = getlines(path)
return lines != nil
end

def getlines(path)
CACHE[path] ||= begin
IO.readlines(path)
rescue
[]
nil
end
end

def getline(path, n)
return nil if n < 1
getlines(path)[n - 1]
lines = getlines(path)
return nil if lines == nil
lines[n - 1]
end
end
end
Expand Down