Capture exceptions in runner tasks #339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Install Raven's at_exit hook whenever rails runner is invoked so that if an exception occurs during the task it will be reported.
eugeneius
force-pushed
the
rails_runner_hook
branch
from
c615574 to
b4d08bc
Compare
Contributor
|
boom That's the second time I've forgotten about the at_exit hook. |
nateberkopec
added a commit
that referenced
this pull request
May 16, 2015
Capture exceptions in runner tasks Fix #325.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #325.
Install Raven's
at_exithook wheneverrails runneris invoked so that if an exception occurs during the task it will be reported.I'm not really sure how to write a good test for this, but from manual testing it seems to work.