Skip to content

Change okjson to encode NaN and Infinity as string, instead of raising error. #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2015
Merged

Change okjson to encode NaN and Infinity as string, instead of raising error. #345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/raven/okjson.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,7 +499,7 @@ def strenc(s)

def numenc(x)
if ((x.nan? || x.infinite?) rescue false)
raise Error, "Numeric cannot be represented: #{x}"
return strenc(x.to_s)
end
"#{x}"
end
Expand Down
6 changes: 4 additions & 2 deletions spec/raven/okjson_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,11 @@
it 'encodes anything that responds to to_s' do
data = [
(1..5),
:symbol
:symbol,
1/0.0,
0/0.0
]
expect(Raven::OkJson.encode(data)).to eq "[\"1..5\",\"symbol\"]"
expect(Raven::OkJson.encode(data)).to eq "[\"1..5\",\"symbol\",\"Infinity\",\"NaN\"]"
end

it 'does not parse scientific notation' do
Expand Down