Update event.rb #346
Merged
Update event.rb #346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Properly scope Digest::MD5, explicitly include md5
Contributor
|
LGTM, but was this causing issues for you somehow? |
Contributor
Author
|
Yes, if you don't have digest/md5 in Ruby and you'd deep in Raven::Event, exciting scoping rules assume that this unseen Digest::MD5 is referring to Raven::Event::Digest::MD5, and it can't find Raven::Event::Digest. |
nateberkopec
added a commit
that referenced
this pull request
Jun 12, 2015
Fix issues with digest/md5 namespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly scope Digest::MD5, explicitly include md5