Rails 5 support #423
Merged
Rails 5 support #423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateberkopec
force-pushed
the
master
branch
3 times, most recently
from
6809be8 to
cd2f174
Compare
Contributor
Author
|
Blocked by a bug in Rails 5, waiting for that fix to be merged and beta2 released. |
|
@nateberkopec is there any way how to use sentry with 5.0.0.beta1 now? |
Contributor
Author
|
@boblin I believe it does work, just with a deprecation warning. |
|
I see. Thank you. I'll try it. |
|
I've tried, but it doesn't work for me. It appears that it sends data, but I don't see anything catched on app.getsentry.com. I've tried also testing rake task with the same result. |
Contributor
|
I think you should fix too. |
Contributor
Author
|
.beta2 is out, I'll update. |
Contributor
Author
|
Link #456 |
| env = env_or_request.respond_to?(:env) ? env_or_request.env : env_or_request | ||
| Raven::Rack.capture_exception(exception, env) | ||
| ensure | ||
| render_exception_without_raven(env, exception) |
There was a problem hiding this comment.
shouldn't you be passing the original argument env_or_request instead of env?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.