Skip to content

Fix UTF-8 conversion for bad exception messages #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2016
Merged

Fix UTF-8 conversion for bad exception messages #426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/raven/processor/utf8conversion.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ def process(value)
value.map { |v| process v }
elsif value.is_a? Hash
value.merge(value) { |_, v| process v }
elsif value.is_a?(Exception) && !value.message.valid_encoding?
clean_exc = value.class.new(clean_invalid_utf8_bytes(value.message))
clean_exc.set_backtrace(value.backtrace)
clean_exc
else
clean_invalid_utf8_bytes(value)
end
Expand Down
7 changes: 7 additions & 0 deletions spec/raven/processors/utf8conversion_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,13 @@
expect(results['invalid']).to eq("invalid utf8 string goes here")
end

it "should cleanup invalid UTF-8 bytes in Exception messages" do
data = Exception.new("invalid utf8 string goes here\255".force_encoding('UTF-8'))

results = @processor.process(data)
expect(results.message).to eq("invalid utf8 string goes here")
end

it 'should keep valid UTF-8 bytes after cleaning' do
data = {}
data['invalid'] = "한국, 中國, 日本(にっぽん)\255".force_encoding('UTF-8')
Expand Down