-
-
Notifications
You must be signed in to change notification settings - Fork 520
Detect release from Capistrano 3 revisions.log #449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lib/raven/configuration.rb
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rails.root should be project_root here, please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, I'm not a Capistrano user, but this blog post suggests the revisions.log file lives right in the application root?
|
Oops, I originally used As for the location of
|
|
We're using Capistrano 3.4.0, and |
|
Can you link to documentation that explains why, and for what versions this change is necessary? |
|
Here's the documentation about Capistrano's file structure; there's no mention of http://capistranorb.com/documentation/getting-started/structure/ I couldn't find anything in the official documentation talking about the removal of http://building.wanelo.com/2014/03/31/capistrano-you-have-changed.html Can you find the specific message in your deploy log output that writes the |
|
Nevermind, I found it. It looks like capistrano/capistrano@b1cbb0c#diff-aa4465f31474e46370f8f1f204f7d51eR204 Changelog here: Diff with previous version: |
lib/raven/configuration.rb
Outdated
| File.read(File.join(project_root, 'REVISION')).strip rescue nil | ||
| version = File.read(File.join(project_root, 'REVISION')).strip rescue nil | ||
|
|
||
| # Capistrano 3+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you could please change this comment to reflect your research (3.0 and 3.1 only I guess?)
|
Just a quick change to that comment and I think this can be merged |
|
All done. Thanks! |
|
@timcheadle sorry, can you squash this into a single commit too? gotta keep our git history (relatively) clean |
|
All done. |
|
Thanks! |
Detect release from Capistrano 3 revisions.log
Capistrano 3 no longer produces a
REVISIONfile, but instead usesrevisions.login the directory aboveRails.root. This fix pulls the release info from the last line of that new file format.