Use Module#prepend only when it exists #477
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use duck typing instead of assuming that certain Ruby versions have specific capabilities.
Contributor
|
Can you rebase this against the latest |
.travis.yml
Outdated
| include: | ||
| - rvm: jruby-1.7.24 | ||
| env: JRUBY_OPTS="--2.0" | ||
| gemfile: gemfiles/rails41.gemfile |
Contributor
There was a problem hiding this comment.
There is no rails41.gemfile on latest master, these need to be omitted.
Contributor
Author
|
|
Contributor
|
Heh, no, I was hoping you would know 😆 |
Contributor
Author
|
Doh! It makes sense...the gemfile doesn't exist, so raven doesn't exist in the bundle. |
Contributor
|
Wow, thanks for the fix, didn't know that something like JRuby 1.7 in 2.0 mode exists.. |
Contributor
Author
|
Thanks @Elektron1c97. I hate to admit that the reason I know about it is that I'm using it in production! |
Contributor
|
Merged in a462449 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JRuby 1.7.x does not have a
Module#prependmethod. #457 made the assumption that if Ruby version is 2.0 or higher, then theprependmethod exists. This affected me because I'm using JRuby 1.7 in "2.0 mode".It's always better to use duck typing instead of assuming that a version of Ruby has specific methods.
I believe it's correct to treat a missing
prependmethod by using the pre-Ruby 2.0 method (insertingOldDebugExceptionsCatcher), and it seems to work correctly. But it may not be the correct behavior.