Fix silence_ready not working for Rails apps #512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Does anyone know what happened with the Travis build? |
Member
|
@ream88 i re-ran the build |
Contributor
Author
|
Ah, ok my local rspec wasn't running at all, and I misinterpreted the rubocop output as test output! |
by invoking the first configure block after your
initializers are called.
Before, using an initializer would generate a
second clients, with the first one still logging
to STDOUT.
Until this is merged, someone can use this in his
application.rb to get the same result:
Rails.application.config.before_configuration do
Raven.configuration.silence_ready = true
end
ream88
force-pushed
the
really-silence-ready
branch
from
bcb5e7d to
9a3bfee
Compare
Contributor
Author
|
Yeah, fixed it now :) |
Member
|
Thanks! |
Contributor
|
I originally did this in https://github.com/getsentry/raven-ruby/pull/450, but @nateberkopec pointed out a use case that it broke: https://github.com/getsentry/raven-ruby/pull/450#issuecomment-178000161 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by invoking the first configure block after your initializers are called. Before, using an initializer would generate a second clients, with the first one still logging to STDOUT.
Until this is merged, someone can use this in his application.rb to get the same result:
See also: https://github.com/getsentry/raven-ruby/issues/492