Do not capture if env doesn't match or DSN not set #518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
this is all vis a vis #513 |
nateberkopec
force-pushed
the
no-capture-when-no-dsn
branch
from
2fecda8 to
679585c
Compare
Previously, even when event *sending* to the server was disabled by lack of a DSN or the current environment not matching the env list, we would still capture a Raven event. This commit causes Raven to not even capture events when it would not send them.
nateberkopec
force-pushed
the
no-capture-when-no-dsn
branch
from
679585c to
6578655
Compare
alexford
pushed a commit
to alexford/raven-ruby
that referenced
this pull request
Jan 1, 2017
- No need to list all MRIs explicitly. - List JRuby, Rubinius minimum versions Fixes getsentry#518 [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, even when event sending to the server was disabled by lack of a DSN or the current environment not matching the env list, we would still capture a Raven event. This commit causes Raven to not even capture events when it would not send them.
cc @dcramer - any legitimate reason people want to capture but not send?
This change is