Fix LocalJumpError in Rails controllers #774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were a few messups here: * The Rails controller tests never tested a "happy case" (that is, no exceptions) * The Rails controller tests didn't check to see the exception they were actually catching - so the LocalJumpError went unnoticed! * You can't `yield` from the block form of `around_action` * I'm not sure why I thought class_eval was necessary here - it isn't. Fix #773
This was referenced Oct 11, 2017
|
Can confirm this fixes the issue for me 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few messups here:
yieldfrom the block form ofaround_actionFix #773