Cookie improvements #904
Closed
Cookie improvements #904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh-m-sharpe
force-pushed
the
cookie_improvements
branch
from
19e5224 to
9969d3e
Compare
josh-m-sharpe
force-pushed
the
cookie_improvements
branch
from
9969d3e to
fedc34f
Compare
|
Seems to work decently, though, I guess it leaves the values in request.cookies inconsistent with the value in the Cookie header. Thoughts on this approach?
|
|
Any updates on this? I'm tired of seeing the following error in our event processing...
|
|
@josh-m-sharpe thanks for the PR! can you add a test case for the fix as well? |
|
I suspect I won't be re-opening this to test it at this point. |
|
closing because the issue has been fixed in #983 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to https://github.com/getsentry/raven-ruby/issues/900