Skip to content

Conversation

@estepnv
Copy link

@estepnv estepnv commented Jan 29, 2020

I understand that it's not memory-efficient, but you are working with business rules which might rely on references.
Consider opting out this behavior, or display a warning somewhere, and this behavior should be documented.
I spent 6 hours of debugging code because of the sentry event. Imagine my feelings when I figure out it's caused by raven.
Fixes https://github.com/getsentry/raven-ruby/issues/903

I understand that it's not memory-efficient, but you are working with business rules which might rely on references.
Consider opting out this behavior, or display a warning somewhere, and this behavior should be documented. 
I spent 6 hours of debugging code because of the sentry event. Imagine my feelings when I figure out it's caused by raven.
@st0012
Copy link
Collaborator

st0012 commented Aug 21, 2020

@estepnv thanks for the fix!
but this approach could increase memory allocation by 16% or more, which is something we should avoid if possible (you can see the detail about this analysis at https://github.com/getsentry/raven-ruby/pull/994's description). so I will close this once #994 is proved working and merged.

@st0012 st0012 added the bug fix label Aug 21, 2020
@st0012 st0012 added this to the 3.0.3 milestone Aug 21, 2020
@st0012 st0012 closed this Aug 21, 2020
@st0012 st0012 removed this from the 3.0.3 milestone Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RemoveCircularReferences mutates/deletes data passed to it

2 participants