Fix #967: 'can't modify frozen String' error on Rails 5.2 and ruby 2.7.1'

[eirvandelden]

This is the change I made locally to fix the FrozenError exception as I encountered it in #967

[st0012]

@eirvandelden thanks for the work! I have fixed the CI build btw, can you rebase the latest master and push again?

[eirvandelden]

Thanks for fixing CI, I’ll rebase the branch tomorrow 👍🏼 Groetjes, Etienne Groetjes, Etienne

…

> Op 6 aug. 2020 om 09:20 heeft Stan Lo ***@***.***> het volgende geschreven:  @eirvandelden thanks for the work! I have fixed the CI build btw, can you rebase the latest master and push again? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[eirvandelden]

@st0012 I've rebased and all test pass 👍

[st0012]

@eirvandelden after digging into the issue, I think a more thorough solution is to avoid using string mutation methods (<<) and just use string concatenation. I also added a test suite with --enable-frozen-string-literal option enabled.

the above changes are made in https://github.com/getsentry/raven-ruby/pull/977. so I will close this one after merging it. thanks again for reporting the issue and sorry for not asking to rebase before giving it a closer look 😢

[eirvandelden]

That's okay, I thought about rewriting the code to no longer using string mutation, but opted not to, because I'm unfamiliar with the code base. I'm glad you took the effort to do it 👍