Fix/Refactor Raven::Cli #989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we take a look at `Raven::Instance#capture_exception`, we can see
that it now always returns an Event or nil/false.
```ruby
if evt = Event.send("from_" + message_or_exc, obj, options)
yield evt if block_given?
if configuration.async?
begin
# We have to convert to a JSON-like hash, because background job
# processors (esp ActiveJob) may not like weird types in the event hash
configuration.async.call(evt.to_json_compatible)
rescue => e
logger.error("async event sending failed: #{e.message}")
send_event(evt, make_hint(obj))
end
else
send_event(evt, make_hint(obj))
end
Thread.current["sentry_#{object_id}_last_event_id".to_sym] = evt.id
evt # <- here
end
```
So all the conditions for Thread/Hash objects can now be removed.
Codecov Report
@@ Coverage Diff @@
## master #989 +/- ##
==========================================
+ Coverage 97.26% 97.76% +0.49%
==========================================
Files 46 46
Lines 2123 2148 +25
==========================================
+ Hits 2065 2100 +35
+ Misses 58 48 -10
Continue to review full report at Codecov.
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #938
It also contains some code removal and test coverage improvements.