-
-
Notifications
You must be signed in to change notification settings - Fork 168
feat(log): support combined LogFilters and RecordMappings #914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #914 +/- ##
==========================================
+ Coverage 73.46% 73.50% +0.03%
==========================================
Files 64 64
Lines 7518 7533 +15
==========================================
+ Hits 5523 5537 +14
- Misses 1995 1996 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in principle, but I have a suggestion for simplifying the code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One weird thing might be that with bitflags
, you can combine Ignore
with any of the others just fine, and the compiler won’t complain, even though it does not make sense.
But thats a minor papercut, not worth wasting time over.
Description
Adds support for combining multiple
LogFilters
when using our integration for thelog
crate.This way, it's possible to map a
log
record to multiple items in Sentry, for example to both alog
and anevent
.This is required for #909.
There, we want to enable logs for records at or above INFO by default, in order to remove the double opt-in, while still sending breadcrumbs for them at the same time.
The changes are analogous with the ones we did for the
tracing
integration here: #847Issues
Close #908
Close RUST-111