-
Notifications
You must be signed in to change notification settings - Fork 184
Made priorities configurable #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Worth noting, I added each parameter as a scalar node to avoid adding complexity to the Extension, but i'm happy to make it an array node and extend the extension if desired.. |
a2a5b00 to
b39d528
Compare
|
Fixed the extra line left behind, oops. |
|
First, thanks for the PR! listener_priorities:
request: 0
kernel_exception: 0
console_exception: 0Is it too much complicated do be done? |
|
@Jean85 should not be, i had done it initially. I'll add some more complexity to the extension but should be good. Gimme a sec. |
b39d528 to
28fc2e6
Compare
|
@Jean85 there you go. I tried to go with making the So i went with the simple approach of making each a scalar parameter, making config nice and clean and leaving the rest hidden behind the bundle wall. Let me know if this needs cleaning up more, i decided to not exclude the |
In order to allow users to move the listeners in their priorities queue the value is now configurable via configuration parameters. In order to maintain BC these values default to 0 which is the current value.
28fc2e6 to
e8942b5
Compare
|
Thanks, it's perfect! 👍 |
|
Thanks! |
In order to allow users to move the listeners in their priorities queue
the value is now configurable via configuration parameters. In order to
maintain BC these values default to 0 which is the current value.
this closes #49.