Switch to MIT license #697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jean85
previously requested changes
Feb 16, 2023
Contributor
Jean85
left a comment
Jean85
left a comment
There was a problem hiding this comment.
The identifier in composer.json should be changed too.
Member
Author
|
Good point, updated |
9 tasks
chadwhitacre
approved these changes
Feb 16, 2023
chadwhitacre
approved these changes
Feb 16, 2023
Member
chadwhitacre
left a comment
chadwhitacre
left a comment
There was a problem hiding this comment.
I've reviewed https://github.com/getsentry/sentry-symfony/search?q=license and this lgtm. 👍
Member
Author
|
@Jean85 Would you mind not blocking merging by requesting changes? A normal review comment suffices, I won't merge it without addressing it 😄 |
Member
I rerequested from @Jean85 and approved, I think we're unblocked? |
Contributor
Sorry, I didn't realize I was blocking! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The license of our SDKs should be MIT.
https://open.sentry.io/licensing/
Part of getsentry/team-ospo#56.