Skip to content

fix: Added timestamp validation to iOS bridge #2338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 29, 2025
Merged

fix: Added timestamp validation to iOS bridge #2338

merged 2 commits into from
Sep 29, 2025

Conversation

@bitsandfoxes
Copy link
Contributor

@bitsandfoxes bitsandfoxes commented Sep 26, 2025 •
edited
Loading

Follow up on #2327 based on the following feedback

In SentryNativeBridgeAddBreadcrumb, the dateFromString: result is directly assigned to breadcrumb.timestamp. If date parsing fails, this can unexpectedly set the timestamp to nil, creating an inconsistency with macOS behavior where the parsed date is validated.

philipphofmann
philipphofmann approved these changes Sep 26, 2025
View reviewed changes
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@bitsandfoxes bitsandfoxes merged commit e517873 into main Sep 29, 2025
54 of 56 checks passed
@bitsandfoxes bitsandfoxes deleted the fix/ios-native-bridge-timestamp-validation branch September 29, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@philipphofmann philipphofmann philipphofmann approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bitsandfoxes @philipphofmann