Skip to content

chore: Install .NET in sdk.yml for version 3 #2372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 24, 2025
Merged

chore: Install .NET in sdk.yml for version 3 #2372

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c85dcd4
Install .NET
bitsandfoxes Oct 24, 2025
938d97e
Runner vs OS?
bitsandfoxes Oct 24, 2025
426faa6
Split Android from Linux-Linux
bitsandfoxes Oct 24, 2025
b42bfa4
Workload Restore
bitsandfoxes Oct 24, 2025
2ec9d13
Don't restore before fetching the submodule
bitsandfoxes Oct 24, 2025
932a194
Put caching back in
bitsandfoxes Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 26 additions & 3 deletions .github/workflows/sdk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,16 +87,39 @@ jobs:
run: |
apt-get update
apt-get install -y zlib1g-dev libcurl4-openssl-dev libssl-dev build-essential cmake curl
set -eo pipefail
curl -sSL --retry 5 https://dot.net/v1/dotnet-install.sh | bash /dev/stdin --channel 9.0 --install-dir /usr/share/dotnet
echo "/usr/share/dotnet" >> $GITHUB_PATH
env:
DEBIAN_FRONTEND: noninteractive

- name: Install .NET SDK (Linux/Android)
if: ${{ runner.os == 'Linux' && steps.cache.outputs.cache-hit != 'true' }}
shell: bash
run: |
set -eo pipefail
DOTNET_VERSION=$(grep -A 1 '"sdk":' global.json | grep '"version":' | sed 's/.*"version": *"\(.*\)".*/\1/')
curl -sSL --retry 5 https://dot.net/v1/dotnet-install.sh | bash /dev/stdin --version $DOTNET_VERSION --install-dir /usr/share/dotnet
echo "/usr/share/dotnet" >> $GITHUB_PATH

- name: Install .NET SDK (macOS)
if: ${{ runner.os == 'macOS' && steps.cache.outputs.cache-hit != 'true' }}
shell: bash
run: |
DOTNET_VERSION=$(grep -A 1 '"sdk":' global.json | grep '"version":' | sed 's/.*"version": *"\(.*\)".*/\1/')
curl -sSL --retry 5 https://dot.net/v1/dotnet-install.sh | bash /dev/stdin --version $DOTNET_VERSION --install-dir $HOME/.dotnet
echo "$HOME/.dotnet" >> $GITHUB_PATH
Copy link

@cursor cursor bot Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: macOS .NET SDK Script Fails to Exit on Error

The macOS .NET SDK installation step is missing set -eo pipefail, unlike its Linux counterpart. This means if the .NET version extraction from global.json fails, the script won't exit immediately, leading to silent issues and potentially confusing errors later in the workflow.

Fix in Cursor Fix in Web


- name: Install .NET SDK (Windows)
if: ${{ runner.os == 'Windows' && steps.cache.outputs.cache-hit != 'true' }}
shell: pwsh
run: |
$dotnetVersion = (Get-Content global.json | ConvertFrom-Json).sdk.version
Invoke-WebRequest -Uri "https://dot.net/v1/dotnet-install.ps1" -OutFile "dotnet-install.ps1"
.\dotnet-install.ps1 -Version $dotnetVersion -InstallDir "$env:ProgramFiles\dotnet"
Copy link

@cursor cursor bot Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: .NET SDK Installation Fails to Update PATH

The Windows .NET SDK installation step doesn't add its install directory to PATH, unlike the Linux and macOS steps. This prevents subsequent steps from finding the dotnet command, causing the build to fail.

Fix in Cursor Fix in Web


- name: Build
if: steps.cache.outputs.cache-hit != 'true'
run: |
git submodule update --init --recursive ${{ steps.env.outputs.submodules }}
dotnet workload restore
dotnet msbuild /t:Build${{ env.TARGET }}SDK /p:Configuration=Release /p:OutDir=other src/Sentry.Unity

- name: Upload build logs on failure
Expand Down
Loading