feat: LifeCycleIntegration and changes to trace generation
#2374
+90
−94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…m/getsentry/sentry-unity into feat/structured-logging-followup1
mujacica
approved these changes
Oct 30, 2025
Base automatically changed from
feat/structured-logging
to
feat/bump-version6
October 30, 2025 14:06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes are the following:
Changes
LifeCycleIntegrationI renamed
SessionIntegrationtoLifeCycleIntegrationsince this is what that does. It'sinternalso it's fine.OnQuittingmoved from the logging integration into theLifeCycleIntegration. The integration now also adds breadcrumbs for application losing and regaining focusChanges to the
TraceGenerationIntegrationLogs are connected via the currently active span. If there is non active it falls back to the trace ID. The integration was regenerating the ID every time the app lost and regained focus, leading to fragmented logs. This also came up in #2210
For now, we can refrain from creating a new trace and keep one around. Span linking might change this in the future.
Results
With this we go from
Before
No indication that the game lost and regained focus. Since the trace got regenerated with gaining focus, disconnected logs.
After