-
-
Notifications
You must be signed in to change notification settings - Fork 59
feat: Add breadcrumb for lowMemory events
#2406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b972499
Subscribe to lowMemory and add breadcrumb
bitsandfoxes bee6505
Updated CHANGELOG.md
bitsandfoxes ac0f5ab
Format code
getsentry-bot f86c7c6
Check the hub
bitsandfoxes f013486
merged
bitsandfoxes c0e28a2
Cache data
bitsandfoxes 3395415
.
bitsandfoxes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| using System.Collections.Generic; | ||
| using Sentry.Integrations; | ||
|
|
||
| namespace Sentry.Unity.Integrations; | ||
|
|
||
| internal class LowMemoryIntegration : ISdkIntegration | ||
| { | ||
| private static readonly Dictionary<string, string> lowMemoryData = new() { { "action", "LOW_MEMORY" } }; | ||
|
|
||
| private IHub _hub = null!; | ||
| private IApplication _application; | ||
|
|
||
| public LowMemoryIntegration(IApplication? application = null) | ||
| { | ||
| _application = application ?? ApplicationAdapter.Instance; | ||
| } | ||
|
|
||
| public void Register(IHub hub, SentryOptions options) | ||
| { | ||
| _hub = hub; | ||
|
|
||
| _application.LowMemory += () => | ||
| { | ||
| if (!_hub.IsEnabled) | ||
| { | ||
| return; | ||
| } | ||
|
|
||
| hub.AddBreadcrumb(new Breadcrumb( | ||
| message: "Low memory", | ||
| type: "system", | ||
| data: lowMemoryData, | ||
| category: "device.event", | ||
| level: BreadcrumbLevel.Warning)); | ||
| }; | ||
bitsandfoxes marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| using System.Linq; | ||
| using NUnit.Framework; | ||
| using Sentry.Unity.Integrations; | ||
| using Sentry.Unity.Tests.Stubs; | ||
|
|
||
| namespace Sentry.Unity.Tests; | ||
|
|
||
| public class LowMemoryIntegrationTests | ||
| { | ||
| private class Fixture | ||
| { | ||
| public TestApplication Application { get; set; } = new(); | ||
| public TestHub Hub { get; set; } = new(); | ||
| public SentryUnityOptions Options { get; set; } = new(); | ||
|
|
||
| public LowMemoryIntegration GetSut() => new(Application); | ||
| } | ||
|
|
||
| private Fixture _fixture = null!; | ||
|
|
||
| [SetUp] | ||
| public void SetUp() | ||
| { | ||
| _fixture = new Fixture(); | ||
| } | ||
|
|
||
| [Test] | ||
| public void LowMemory_DisabledHub_NoBreadcrumbAdded() | ||
| { | ||
| _fixture.Hub = new TestHub(false); | ||
| var sut = _fixture.GetSut(); | ||
|
|
||
| sut.Register(_fixture.Hub, _fixture.Options); | ||
| _fixture.Application.OnLowMemory(); | ||
|
|
||
| Assert.Zero(_fixture.Hub.ConfigureScopeCalls.Count); | ||
| } | ||
|
|
||
| [Test] | ||
| public void LowMemory_EnabledHub_BreadcrumbAdded() | ||
| { | ||
| var sut = _fixture.GetSut(); | ||
|
|
||
| sut.Register(_fixture.Hub, _fixture.Options); | ||
| _fixture.Application.OnLowMemory(); | ||
|
|
||
| var configureScope = _fixture.Hub.ConfigureScopeCalls.Single(); | ||
| var scope = new Scope(_fixture.Options); | ||
| configureScope(scope); | ||
| var actualCrumb = scope.Breadcrumbs.Single(); | ||
|
|
||
| Assert.AreEqual("Low memory", actualCrumb.Message); | ||
| Assert.AreEqual("device.event", actualCrumb.Category); | ||
| Assert.AreEqual("system", actualCrumb.Type); | ||
| Assert.AreEqual(BreadcrumbLevel.Warning, actualCrumb.Level); | ||
| Assert.NotNull(actualCrumb.Data); | ||
| Assert.AreEqual("LOW_MEMORY", actualCrumb.Data?["action"]); | ||
| } | ||
|
|
||
| [Test] | ||
| public void LowMemory_MultipleTriggers_MultipleBreadcrumbsAdded() | ||
| { | ||
| var sut = _fixture.GetSut(); | ||
|
|
||
| sut.Register(_fixture.Hub, _fixture.Options); | ||
| _fixture.Application.OnLowMemory(); | ||
| _fixture.Application.OnLowMemory(); | ||
| _fixture.Application.OnLowMemory(); | ||
|
|
||
| Assert.AreEqual(3, _fixture.Hub.ConfigureScopeCalls.Count); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.