feat: Split Sentry.Unity.Native into desktop and console
#2441
Conversation
|
bitsandfoxes
changed the title
Sentry.Unity.Native from console (static)Sentry.Unity.Native into desktop and console
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| GameCoreXboxOne: GameCoreXboxOne | ||
| second: | ||
| enabled: 1 | ||
| enabled: 0 |
There was a problem hiding this comment.
Bug: Missing XboxOne platform configuration in Native.dll.meta
The Sentry.Unity.Native.Console.dll.meta file enables XboxOne (with enabled: 1), but Sentry.Unity.Native.dll.meta is missing the corresponding XboxOne platform entry to disable it. While GameCoreScarlett and GameCoreXboxOne were both explicitly set to enabled: 0 in the Native version, the XboxOne platform configuration entry is absent entirely. This inconsistency could cause both DLLs to be available on XboxOne or lead to unexpected platform resolution behavior.
Additional Locations (1)
There was a problem hiding this comment.
While GameCoreScarlett and GameCoreXboxOne were both explicitly set to enabled: 0 in the Native version, the XboxOne platform configuration entry is absent entirely.
what? lgtm 😕
| #if SENTRY_NATIVE_CONSOLE | ||
| [DllImport("__Internal", EntryPoint = "vsnprintf")] | ||
| #else | ||
| [DllImport("msvcrt", EntryPoint = "vsnprintf")] | ||
| #endif | ||
| private static extern int vsnprintf_windows(IntPtr buffer, UIntPtr bufferSize, IntPtr format, IntPtr args); | ||
|
|
||
| #if SENTRY_NATIVE_CONSOLE | ||
| [DllImport("__Internal", EntryPoint = "vsnprintf")] | ||
| #else | ||
| [DllImport("libc", EntryPoint = "vsnprintf")] | ||
| #endif | ||
| private static extern int vsnprintf_linux(IntPtr buffer, UIntPtr bufferSize, IntPtr format, IntPtr args); |
There was a problem hiding this comment.
Isn't this where the ps5 vsnprintf issue was coming from? Or was it a different function
There was a problem hiding this comment.
Yes. But #2433 is not merged yet. I'll rebase it on this one.
| GameCoreXboxOne: GameCoreXboxOne | ||
| second: | ||
| enabled: 1 | ||
| enabled: 0 |
There was a problem hiding this comment.
While GameCoreScarlett and GameCoreXboxOne were both explicitly set to enabled: 0 in the Native version, the XboxOne platform configuration entry is absent entirely.
what? lgtm 😕
#skip-changelog