Fix issues in FAB plugin package #1024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpnurmi
reviewed
Jul 23, 2025
|
|
||
| bool FSentryModule::IsMarketplaceVersion() | ||
| { | ||
| return IsMarketplace; |
Collaborator
There was a problem hiding this comment.
was IsMarketplace left unused? should it be removed?
Collaborator
Author
There was a problem hiding this comment.
Yes, I believe it can be safely removed.
Additional context: IsMarketplace value was set by CI script depending on plugin package type (see 5ef0806)
jpnurmi
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issues discovered in FAB version of the plugin (
1.0.0-beta.5) which for the first time includes executables and scripts.Key changes:
crashpad_handler.exeto plugin's build output dir in post-build step (by default Epic obfuscates any extra binaries from there before publishing the package)githubvsmarketplace)#skip-changelog