Fix Android crash when logging from multiple threads #1092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustanivsky
changed the title
jclass references on Android![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
plugin-dev/Source/Sentry/Private/Android/Infrastructure/AndroidSentryJavaClasses.cpp
Show resolved
Hide resolved
mujacica
approved these changes
Sep 26, 2025
limbonaut
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds caching of Java class references for Android to avoid intermittent crashes when creating
FSentryJavaObjectWrapperobjects (e.g. during intensive logging from multiple threads when Unreal SDK could instantiate large number of breadcrumb wrappers).Additionally, it fixes memory leak during Sentry level conversion from Java to C++ (global ref was obtained but never freed):
sentry-unreal/plugin-dev/Source/Sentry/Private/Android/Infrastructure/AndroidSentryConverters.cpp
Line 20 in 35af9d1
Suggested changes should also improve overall performance by removing repeated JNI class lookups (mentioned here).
Closes #848