Skip to content

Commit 76e7d46

Browse files
committed
Rename isHidden to isDisabled
1 parent 7569192 commit 76e7d46

File tree

2 files changed

+13
-6
lines changed

2 files changed

+13
-6
lines changed

static/app/components/devtoolbar/components/app.tsx

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,11 @@ import PanelRouter from './panelRouter';
1717
export default function App() {
1818
const placement = usePlacementCss();
1919
const [visibility] = useVisibility();
20-
const [isHidden, setIsHidden] = useSessionStorage('hide_employee_devtoolbar', false);
21-
if (isHidden) {
20+
const [isDisabled, setIsDisabled] = useSessionStorage(
21+
'hide_employee_devtoolbar',
22+
false
23+
);
24+
if (isDisabled) {
2225
return null;
2326
}
2427

@@ -28,9 +31,9 @@ export default function App() {
2831
<Global styles={loadingIndicatorCss} />
2932
<Global styles={avatarCss} />
3033
<div css={[fixedContainerBaseCss, placement.fixedContainer.css, {visibility}]}>
31-
{isHidden ? null : (
34+
{isDisabled ? null : (
3235
<Fragment>
33-
<Navigation setIsHidden={setIsHidden} />
36+
<Navigation setIsDisabled={setIsDisabled} />
3437
<Suspense fallback={<LoadingPanel />}>
3538
<PanelRouter />
3639
</Suspense>

static/app/components/devtoolbar/components/navigation.tsx

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,11 @@ import useToolbarRoute from '../hooks/useToolbarRoute';
99
import {navigationButtonCss, navigationCss} from '../styles/navigation';
1010
import {resetButtonCss, resetDialogCss} from '../styles/reset';
1111

12-
export default function Navigation({setIsHidden}: {setIsHidden: (val: boolean) => void}) {
12+
export default function Navigation({
13+
setIsDisabled,
14+
}: {
15+
setIsDisabled: (val: boolean) => void;
16+
}) {
1317
const {trackAnalytics} = useConfiguration();
1418
const placement = usePlacementCss();
1519

@@ -26,7 +30,7 @@ export default function Navigation({setIsHidden}: {setIsHidden: (val: boolean) =
2630
<NavButton panelName="feedback" label={'User Feedback'} icon={<IconMegaphone />} />
2731
<HideButton
2832
onClick={() => {
29-
setIsHidden(true);
33+
setIsDisabled(true);
3034
trackAnalytics?.({
3135
eventKey: `devtoolbar.nav.hide.click`,
3236
eventName: `devtoolbar: Hide devtoolbar`,

0 commit comments

Comments
 (0)